separate out training for fault tolerance #2311
Merged
+524
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
tushar00jain
force-pushed
the
pr2311
branch
5 times, most recently
from
d6a30aa to
be416e3
Compare
tushar00jain
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
tushar00jain
force-pushed
the
pr2311
branch
3 times, most recently
from
751c4bc to
f012f36
Compare
wwwjn
reviewed
Feb 2, 2026
fegin
requested changes
Feb 4, 2026
tushar00jain
force-pushed
the
pr2311
branch
3 times, most recently
from
f4dcc0d to
2f05a79
Compare
tianyu-l
requested changes
Feb 5, 2026
fegin
reviewed
Feb 6, 2026
tushar00jain
force-pushed
the
pr2311
branch
2 times, most recently
from
512d506 to
5f93807
Compare
tushar00jain
force-pushed
the
pr2311
branch
3 times, most recently
from
89a5d90 to
7022f5e
Compare
tushar00jain
force-pushed
the
pr2311
branch
2 times, most recently
from
2302d58 to
c2f2098
Compare
wwwjn
reviewed
Feb 10, 2026
fegin
approved these changes
Feb 11, 2026
Summary: - extract logic in train.py that was different for ft in separate functions - override these functions in ft's train.py Test Plan: Run lighthouse and two replicas ```bash RUST_BACKTRACE=1 torchft_lighthouse --min_replicas 2 --quorum_tick_ms 100 --join_timeout_ms 10000 TRAIN_FILE=torchtitan.experiments.ft.train CONFIG_FILE=./torchtitan/models/llama3_ft/train_configs/debug_model.toml CUDA_VISIBLE_DEVICES=0 NGPU=1 ./run_train.sh --parallelism.data_parallel_shard_degree=1 --fault_tolerance.enable --fault_tolerance.group_size=2 --fault_tolerance.replica_id=0 TRAIN_FILE=torchtitan.experiments.ft.train CONFIG_FILE=./torchtitan/models/llama3_ft/train_configs/debug_model.toml CUDA_VISIBLE_DEVICES=1 NGPU=1 ./run_train.sh --parallelism.data_parallel_shard_degree=1 --fault_tolerance.enable --fault_tolerance.group_size=2 --fault_tolerance.replica_id=1 ```
tianyu-l
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
Run lighthouse and two replicas